Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow for wildcard in patcher search #75

Open
indykoning opened this issue Feb 26, 2021 · 2 comments · May be fixed by #86
Open

Allow for wildcard in patcher search #75

indykoning opened this issue Feb 26, 2021 · 2 comments · May be fixed by #86

Comments

@indykoning
Copy link

indykoning commented Feb 26, 2021

Is your feature request related to a problem? Please describe.
In an attempt to keep everything in modules it would be nice to have wildcards work in the search configuration settings.
This would allow us to keep the patches in the relevant module without having to add every single module path to the search lising

Describe the solution you'd like
Accepting wildcards in the search configuration

"extra": {
        "patcher": {
            "search": ["patches", "app/code/<vendor>/*/patches", "vendor/<vendor>/*/patches"]
        }
    }

Describe alternatives you've considered
manually adding the path per module (which is what i'll do for the time being).

@indykoning
Copy link
Author

My guess is if we add glob around this line and merge it with the paths glob patterns could work

@allanpaiste
Copy link
Contributor

@indykoning you are correct. I'd be easy to implement as well + would make it more in tune with some other features that do allow wildcards to be used. Will look into this asap.

@indykoning indykoning linked a pull request Oct 5, 2021 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants