Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use drupol/phposinfo #32

Closed
drupol opened this issue Jul 13, 2019 · 3 comments
Closed

Use drupol/phposinfo #32

drupol opened this issue Jul 13, 2019 · 3 comments

Comments

@drupol
Copy link

drupol commented Jul 13, 2019

Hi !

It seems that tivie/php-os-detector is a dependency. It can produces false results, see the corresponding issue: tivie/php-os-detector#3

Based on this, I've created my own package: drupol/phposinfo that fixes the issue.

This issue is to propose the replacement of tivie/php-os-detector with drupol/phposinfo.

@allanpaiste
Copy link
Contributor

I'm totally on board with this switch, but there's a small problem. The main value of the whole plugin usually stems from someone wanting to patch older software, thus the low PHP version requirement (>= 5.3). I'd rather not lose that which makes me wonder if you'd be willing to branch the code to have two majors: one for older PHP (that'd just remain in maintenance) and newer one that would be the one that you currently have :/

@allanpaiste
Copy link
Contributor

Currently keeping the use of tivie's package due to the need of for keeping lower php version support around (patcher module mostly used on systems that require some fix for discontinued components to be back-ported).

@drupol
Copy link
Author

drupol commented Jul 22, 2019

Hi,

I release a version for PHP 5.6.

Let me know if you change your mind.

thx

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants