We read every piece of feedback, and take your input very seriously.
To see all available qualifiers, see our documentation.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Currently the contract uses 365 days for calculations, this is a very rough estimate of an year.
365 days
While the impact of this value being not accurate would be negligible, there is no reason for using the correct value for 1 full year..
I suggest introducing a constant:
//time in seconds for a tropical year uint256 public constant T_YEAR = 365 days + 5 hours + 48 minutes + 45 seconds;
And use whenever is needed to calculate over 1 year.
The text was updated successfully, but these errors were encountered:
3esmit
No branches or pull requests
Currently the contract uses
365 days
for calculations, this is a very rough estimate of an year.While the impact of this value being not accurate would be negligible, there is no reason for using the correct value for 1 full year..
I suggest introducing a constant:
And use whenever is needed to calculate over 1 year.
The text was updated successfully, but these errors were encountered: