Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Introduce a YEAR constant to represent tropical year in seconds #57

Open
3esmit opened this issue Oct 16, 2024 · 0 comments
Open

Introduce a YEAR constant to represent tropical year in seconds #57

3esmit opened this issue Oct 16, 2024 · 0 comments

Comments

@3esmit
Copy link
Contributor

3esmit commented Oct 16, 2024

Currently the contract uses 365 days for calculations, this is a very rough estimate of an year.

While the impact of this value being not accurate would be negligible, there is no reason for using the correct value for 1 full year..

I suggest introducing a constant:

//time in seconds for a tropical year
uint256 public constant T_YEAR = 365 days + 5 hours + 48 minutes + 45 seconds;

And use whenever is needed to calculate over 1 year.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Development

No branches or pull requests

2 participants