Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

VaadinAwareSecurityContextHolderStrategy should collaborate with customizations of the security context repository #19992

Open
jorgheymans opened this issue Sep 19, 2024 · 0 comments

Comments

@jorgheymans
Copy link

In our spring-security configuration we have this:

    http.securityContext(
            customizer ->
                // store the security context as request attribute and not session
                customizer.securityContextRepository(
                    new RequestAttributeSecurityContextRepository()))

However VaadinAwareSecurityContextHolderStrategy attempts to fetch the SecurityContext from the session first and falls back to a self managed ThreadLocal storage. Should it not just assume that, if a RequestAttributeSecurityContextRepository is configured, it can fetch it from there instead ?

@vaadin vaadin deleted a comment Sep 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants
@jorgheymans and others