Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add usage stats for Flow auto layout feature #19953

Closed
mshabarov opened this issue Sep 13, 2024 · 1 comment · Fixed by #20224
Closed

Add usage stats for Flow auto layout feature #19953

mshabarov opened this issue Sep 13, 2024 · 1 comment · Fixed by #20224
Assignees
@tltv
Labels
enhancement prerelease version for Vaadin 24.5.0 Released with Vaadin 24.5.0.rc2

Comments

@mshabarov
Copy link
Contributor

mshabarov commented Sep 13, 2024 •
edited
Loading

Describe your motivation

Add usage statistics for Flow auto layout feature, aka @Layout.
Should just mark it as used, when detected.
We can discriminate what combination is used - Flow, Hilla or both with use of other stats params.

Additional context

Should target 24.5+.
@mshabarov mshabarov changed the title Add stats parameters for auto layouts Add usage stats for Flow auto layout feature Oct 10, 2024
@tltv tltv self-assigned this Oct 10, 2024
tltv added a commit that referenced this issue Oct 10, 2024
@tltv
fix: add usage stats for automatic menu
650f5f4 
Fixes: #19953
@tltv tltv mentioned this issue Oct 10, 2024
Merged
@tltv tltv closed this as completed in 4924daa Oct 11, 2024
vaadin-bot pushed a commit that referenced this issue Oct 11, 2024
@tltv @vaadin-bot
fix: add usage stats for automatic menu (#20224)
b35ca19 
Fixes: #19953
vaadin-bot added a commit that referenced this issue Oct 11, 2024
@vaadin-bot @tltv
fix: add usage stats for automatic menu (#20224) (#20233)
6612287 
Fixes: #19953

Co-authored-by: Tomi Virtanen <[email protected]>
@vaadin-bot
Copy link
Collaborator

This ticket/PR has been released with Vaadin 24.5.0.rc2 and is also targeting the upcoming stable 24.5.0 version.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@tltv tltv

Labels
enhancement prerelease version for Vaadin 24.5.0 Released with Vaadin 24.5.0.rc2
Projects
Vaadin Flow enhancements backlog (Vaadin 10+)
Status: Done / Pending Release
Vaadin Flow ongoing work (Vaadin 10+)
Status: Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: add usage stats for automatic menu vaadin/flow
3 participants
@tltv @vaadin-bot @mshabarov