Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate to js_interop #407

Merged
merged 2 commits into from
Feb 20, 2024
Merged

Migrate to js_interop #407

merged 2 commits into from
Feb 20, 2024

Conversation

deepak786
Copy link
Collaborator

  • Migrate usage of dart:html to package:web
  • Migrate usage of dart:js, dart:js_util, and package:js to dart:js_interop

See https://dart.dev/interop/js-interop/package-web and https://dart.dev/interop/js-interop/past-js-interop

Fixes #406

@deepak786 deepak786 self-assigned this Feb 18, 2024
@deepak786 deepak786 marked this pull request as ready for review February 18, 2024 19:59
@deepak786 deepak786 added enhancement New feature or request platform-web Specific to Web platform labels Feb 18, 2024
Copy link
Collaborator

@Zazo032 Zazo032 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not familiar with web package but the migration looks good to me by checking the docs

@deepak786 deepak786 merged commit 63bdceb into master Feb 20, 2024
3 checks passed
@deepak786 deepak786 deleted the migrate-js-interop branch February 20, 2024 18:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request platform-web Specific to Web platform
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Migrate to package:web to support WASM
2 participants