Add last Utility #65

Puffy1215 · 2024-07-15T15:26:39Z

I implemented the last utility in #18.

Limitations

I only implemented support for Unix
Several flags from GNU last were not implemented.
There are some slight output differences between GNU last and this implementation. They can be easily cleared up given more time. For example GNU last prints the relative time since the last crash, while this doesn't do that quite yet.

Tests
I added some tests too to go along with the PR. They are kind of simplistic though in that they only do a check to verify there was some output. The timestamp checks only do a simplistic regex check on the output.

sylvestre · 2024-07-15T15:48:24Z

src/uu/last/Cargo.toml

+
+# See more keys and their definitions at https://doc.rust-lang.org/cargo/reference/manifest.html
+


Suggested change

# See more keys and their definitions at https://doc.rust-lang.org/cargo/reference/manifest.html

sylvestre · 2024-07-15T15:53:08Z

src/uu/last/src/platform/unix.rs

+
+        // "%b %e %H:%M"
+        let time_format: Vec<time::format_description::FormatItem> =
+            time::format_description::parse(description).unwrap();


why not handling the error ? unwrap seems risky, no ? :)

sylvestre · 2024-07-15T15:53:12Z

src/uu/last/src/platform/unix.rs

+        // "%b %e %H:%M"
+        let time_format: Vec<time::format_description::FormatItem> =
+            time::format_description::parse(description).unwrap();
+        ut.login_time().format(&time_format).unwrap() // LC_ALL=C


sylvestre · 2024-07-15T15:59:22Z

src/uu/last/src/platform/unix.rs

+            if counter >= self.limit && self.limit > 0 {
+                break;
+            }
+            // println!("|{}| |{}| |{}|", ut.user(), time_string(&ut), ut.tty_device());


please remove the comments

sylvestre · 2024-07-17T11:58:24Z

i guess you saw it but the builds are failing

Puffy1215 · 2024-07-17T12:07:43Z

i guess you saw it but the builds are failing

Windows and macOS is still broken. I'll work on fixing those. I will also fix the still existing linting issues.

codecov · 2024-07-17T14:42:17Z

Codecov Report

Attention: Patch coverage is 63.01370% with 135 lines in your changes missing coverage. Please review.

Project coverage is 58.08%. Comparing base (a87683f) to head (633aea3).
Report is 27 commits behind head on main.

Files with missing lines	Patch %	Lines
src/uu/last/src/platform/unix.rs	56.65%	127 Missing ⚠️
src/uu/last/src/platform/windows.rs	0.00%	5 Missing ⚠️
tests/by-util/test_last.rs	93.47%	3 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##             main      #65      +/-   ##
==========================================
+ Coverage   55.36%   58.08%   +2.71%     
==========================================
  Files          17       21       +4     
  Lines        1472     1849     +377     
  Branches      243      313      +70     
==========================================
+ Hits          815     1074     +259     
- Misses        641      773     +132     
+ Partials       16        2      -14

Flag	Coverage Δ
macos_latest	`57.56% <54.06%> (+0.22%)`	⬆️
ubuntu_latest	`58.13% <57.50%> (+7.39%)`	⬆️
windows_latest	`0.16% <0.00%> (-0.01%)`	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Puffy1215 · 2024-07-22T14:23:07Z

It looks like I have everything working now. The existing errors appear to be from other utilities.

failures:
    test_mountpoint::test_invalid_arg
    test_rev::test_invalid_arg

sylvestre · 2024-07-24T22:30:01Z

dunno if it is hard to do but could you please add tests with an invalid /var/log/wtmp to check that the error management is properly done ? thanks

Puffy1215 · 2024-07-29T13:32:05Z

dunno if it is hard to do but could you please add tests with an invalid /var/log/wtmp to check that the error management is properly done ? thanks

Added one test so far that matches the behavior with the linux org implementation. That seems like the only test I could get working so far. There were some discrepancies I noticed that I think are beyond my implementation, and involve the UtmpxIter code.

For example, if you have a file of arbitrary bytes (Say a file of one long string of all 'a' characters) which can fit into Utmpx struct, the linux org implementation is able to read it into the fields and display it. However, with our implementation, it does not load any of them into a struct, and so displays nothing.

sylvestre · 2024-08-01T20:19:14Z

a bunch of jobs are failing, could you please have a look?

Like:


error: length comparison to zero
   --> src/uu/last/src/platform/unix.rs:190:16
    |
190 |             if ut_stack.len() == 0 {
    |                ^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `ut_stack.is_empty()`
    |
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero
    = note: `-D clippy::len-zero` implied by `-D warnings`
    = help: to override `-D warnings` add `#[allow(clippy::len_zero)]`

error: useless conversion to the same type: `i64`
   --> src/uu/last/src/platform/unix.rs:275:62
    |
275 |         let time = time::OffsetDateTime::from_unix_timestamp(secs.into())
    |                                                              ^^^^^^^^^^^ help: consider removing `.into()`: `secs`
    |
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion
    = note: `-D clippy::useless-conversion` implied by `-D warnings`
    = help: to override `-D warnings` add `#[allow(clippy::useless_conversion)]`

error: useless conversion to the same type: `u64`
   --> src/uu/last/src/platform/unix.rs:277:36
    |
277 |             + Duration::from_nanos(nsecs.into());
    |                                    ^^^^^^^^^^^^ help: consider removing `.into()`: `nsecs`
    |
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion

error: useless conversion to the same type: `uucore::utmpx::time::OffsetDateTime`
   --> src/uu/last/src/platform/unix.rs:284:13
    |
284 |             OffsetDateTime::from(time).replace_offset(offset) + Duration::from_secs(offset_secs);
    |             ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider removing `OffsetDateTime::from()`: `time`
    |
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion

cakebaker · 2024-09-17T14:29:01Z

@Puffy1215 ping?

The GitHub runner images do not contain "still logged in" as no user logs into the system. Processes are only running, so only "still running" is present.

GitHub's Linux images only have "still running". The MacOS images have "still logged in". The regex check was changed to account for both options.

sylvestre reviewed Jul 15, 2024

View reviewed changes

sylvestre force-pushed the main branch 2 times, most recently from a59a41f to b4087a7 Compare July 24, 2024 22:27

Puffy1215 added 16 commits September 19, 2024 14:36

Add the initial implementation of the last utility

4f1d377

tests: Added tests for last util

0443684

last: Reformatted unix.rs

6349faf

last: Fixed time formatting issues

79564b6

last: Fixed missing "- crash" message

33d831e

last: Removed wtmp check in test

3dac6f0

last: Fixed documentation and help output

da300ea

last: Removed unused imports

47be2f7

last: Added licensing to files

332ddd6

last: Remove unneeded comment from Cargo.toml

2336aec

last: Replace unwrap with unwrap_or_default

9dca98a

last: Remove unneeded comment from test

f0c2dd9

last: Remove unused variable and is_quoted function

0f36ea9

last: Fix clippy warnings

5639ac2

last: Simplified last test case

8ca0cf2

The GitHub runner images do not contain "still logged in" as no user logs into the system. Processes are only running, so only "still running" is present.

last: Fix Cargo formatting errors

aa71ca0

Puffy1215 and others added 12 commits September 19, 2024 14:36

last: Limit Unix module to just Unix

e0bb411

last: Generalized regex test

2687722

GitHub's Linux images only have "still running". The MacOS images have "still logged in". The regex check was changed to account for both options.

last: Account for unsupported Windows module

dfa118b

last: Remove macOS from -x test

d5b0fc6

Added earliest timestamp message in output

e73a608

Added test_short_invalid_utmp_file

fd64c73

Linted code (unix.rs and test_last.rs) to standard

1abe14e

Fixed file start time to use correct formatting. Optimized

9edae58

Fixed regex in test. Added str constants for time formatting

4e5c481

last: fix invalid cfg in test

d84a6ac

last: ignore failing test

58e7b69

last: fix clippy warnings

95d83aa

cakebaker force-pushed the main branch from a249bc5 to 95d83aa Compare September 19, 2024 13:23

last: use MetaDataExt for unix instead of linux

633aea3

cakebaker requested a review from sylvestre September 19, 2024 14:17

sylvestre merged commit 49fc7ff into uutils:main Sep 19, 2024
15 checks passed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add last Utility #65

Add last Utility #65

Puffy1215 commented Jul 15, 2024

sylvestre Jul 15, 2024

sylvestre Jul 15, 2024

sylvestre Jul 15, 2024

sylvestre Jul 15, 2024

sylvestre commented Jul 17, 2024

Puffy1215 commented Jul 17, 2024

codecov bot commented Jul 17, 2024 •

edited

Loading

Puffy1215 commented Jul 22, 2024 •

edited

Loading

sylvestre commented Jul 24, 2024

Puffy1215 commented Jul 29, 2024

sylvestre commented Aug 1, 2024

cakebaker commented Sep 17, 2024


		# See more keys and their definitions at https://doc.rust-lang.org/cargo/reference/manifest.html

Add last Utility #65

Add last Utility #65

Conversation

Puffy1215 commented Jul 15, 2024

sylvestre Jul 15, 2024

Choose a reason for hiding this comment

sylvestre Jul 15, 2024

Choose a reason for hiding this comment

sylvestre Jul 15, 2024

Choose a reason for hiding this comment

sylvestre Jul 15, 2024

Choose a reason for hiding this comment

sylvestre commented Jul 17, 2024

Puffy1215 commented Jul 17, 2024

codecov bot commented Jul 17, 2024 • edited Loading

Codecov Report

Puffy1215 commented Jul 22, 2024 • edited Loading

sylvestre commented Jul 24, 2024

Puffy1215 commented Jul 29, 2024

sylvestre commented Aug 1, 2024

cakebaker commented Sep 17, 2024

codecov bot commented Jul 17, 2024 •

edited

Loading

Puffy1215 commented Jul 22, 2024 •

edited

Loading