Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

watch: implement --interval #25

Open
sylvestre opened this issue Mar 2, 2024 · 3 comments
Open

watch: implement --interval #25

sylvestre opened this issue Mar 2, 2024 · 3 comments
Labels
good first issue Good for newcomers watch

Comments

@sylvestre
Copy link
Contributor

      -n, --interval seconds
              Specify update interval.  The command will not allow quicker than 0.1 second inter-
              val,  in  which the smaller values are converted. Both '.' and ',' work for any lo-
              cales. The WATCH_INTERVAL environment can be used to persistently set a non-default
              interval (following the same rules and formatting).
@sylvestre sylvestre added good first issue Good for newcomers watch labels Mar 2, 2024
@maxer137
Copy link
Contributor

maxer137 commented Apr 1, 2024

I am interested in creating an implementation for this.
Though, I am having some difficulty figuring out the code coverage locally before submitting a merge request.

Shall I create a merge request and then add the tests, or the other way around?
If I should add the tests first; Do you have a method of checking code coverage locally?

@sylvestre
Copy link
Contributor Author

And both in the same pr

@cakebaker
Copy link
Contributor

The main functionality has been implemented in the meantime. What remains is the handling of WATCH_INTERVAL.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers watch
Projects
Status: No status
Development

No branches or pull requests

3 participants