Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update obsolete OS icons/logo #6196

Open
wants to merge 6 commits into
base: main
Choose a base branch
from
Open

Conversation

mohsenbakhit
Copy link

Adds:

  • New updated icons for some OS's whose logos have changed since.

Addressing #5938

@tifasoftware
Copy link

The old logo for windows9x is visually better than the proposed.

@mohsenbakhit
Copy link
Author

@tifasoftware I did think so too. Any other changes you would suggest?

@rxhfcy
Copy link

rxhfcy commented Mar 16, 2024

Thanks for doing these. However, could you double-check that the aspect ratio is correct for each new icon (i.e. not horizontally/vertically squished/stretched)?

At least these looked slightly off to me, but please triple-check every icon:

  • Arch Linux icon: slightly too narrow (horizontally squished)?

  • NetBSD icon: horizontally squished?

  • Slackware icon: not a circle -> horizontally stretched?

  • Do some of the icons look too "fuzzy" (not sharp enough) up close, e.g. Arch?

  • Also, is the Android logo the correct one? Different sources seem to disagree (coloring, especially the color of the eyes?)

@rxhfcy
Copy link

rxhfcy commented Mar 16, 2024

The old logo for windows9x is visually better than the proposed.

I don’t understand this comment. Surely the right thing to do is to use whatever the correct official logo is/was, rather than critique which logo is somehow "better"?

@mohsenbakhit
Copy link
Author

mohsenbakhit commented Mar 16, 2024

@rxhfcy I went back and checked, and you are right. Some of the photos did seem squished so I am redoing them to make sure the original aspect ratio is intact while fitting in a 128px square. With regards to fuzziness, I downloaded most of the PNGs from the distros official websites, so there is so much one can do about quality in that small frame.

About the android logo should I instead use the 3d logo that was announced more recently?

Also about the windows9x, I believe the titled icon was officially used by Microsoft for the release of 95 and 98, should I instead add that icon?

@rxhfcy
Copy link

rxhfcy commented Mar 16, 2024

@mohsenbakhit Just try to figure out which logo is most likely the correct/latest one (for both Android and Win9x), and then ask the maintainer (osu) to review/merge when you think this pull request is "ready"

However, here are my notes:

  • I believe Slackware’s icon (image from the middle of this official? page) is meant to be very circular (your version is still horizontally stretched)
  • Should the actual word "android" be included in the Android logo, and should the eyes be white, not transparent? (I don't know the answers to these questions, just asking)

@mohsenbakhit
Copy link
Author

@osy I think this PR is merge-ready.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants