Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix call of usage when packing dependencies for one architecture only #5432

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

gahfy
Copy link

@gahfy gahfy commented Jul 7, 2023

The doc stated to run ./scripts/pack_dependencies.sh . macos arm64 x86_64 to pack dependencies for universal binaries.

However, if you just want to build it for running it locally with the command ./scripts/pack_dependencies.sh . macOS arm64, the usage() method will get called.

This fix let you pack dependencies for one architecture only.

The doc stated to run `./scripts/pack_dependencies.sh . macos arm64 x86_64` to pack dependencies for universal binaries.

However, if you just want to build it for running it locally with the command `./scripts/pack_dependencies.sh . macOS arm64`, the `usage()` method will get called.

This fix let you pack dependencies for one architecture only.
@osy
Copy link
Contributor

osy commented Aug 19, 2023

Sorry, what's the purpose of running this with one architecture?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants