Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug: Gating events can cause MOSAIC to fail #40

Open
forstater opened this issue Mar 4, 2015 · 4 comments
Open

Bug: Gating events can cause MOSAIC to fail #40

forstater opened this issue Mar 4, 2015 · 4 comments

Comments

@forstater
Copy link

Problem: Channel gating can cause analysis to stall or terminate. MOSAIC should gracefully handle gating events and remove them prior to analysis or avoid fitting them.

@shadowk29
Copy link
Collaborator

As a suggestion along these lines, have the user input the expected range of baseline currents, and set the program to ignore any sections of data for which the baseline deviates outside of that range. I have used this in the past, it is simple and effective.

@abalijepalli
Copy link
Member

The other problem is the event partition code classifies a long gating step (with tens of thousands of data points) as an event causing the fit algorithm to get bogged down.

@forstater
Copy link
Author

Two possible solutions:

(a) Would it be possible to set a maximum event duration cutoff (or number of points)? In my experience, gating events are generally partitioned but cannot be fit.

(b) One less generalized option - for systems (such as EBS) which can rapidly change voltage in response to gating , could the gating observation time and clearing time be used to remove these events?

FYI - I recall opening a more detailed ticket about this at one point on bitbucket, including some test files, any chance you're still able to access the bitbucket issue tracker?

@abalijepalli
Copy link
Member

Reproducing Bitbucket issue 23:

Analysis fails when encountering a gating channel. No further events are fit and software appears to continue attempting to process this event indefinitely. Attached is a zip file containing the necessary information to replicate this problem. This occurs in both the current development version and in v1.0a5.1. Below are images of the event in question.

2567322792-b

783953352-a

abalijepalli added a commit that referenced this issue Mar 20, 2015
	- Added a maximum event length setting (MaxEventLength) that automatically rejects events longer than the specified value.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants