Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Accept constraints in URI assert without hostnames or protocols #190

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Accept constraints in URI assert without hostnames or protocols #190

wants to merge 1 commit into from

Conversation

nunofgs
Copy link
Contributor

@nunofgs nunofgs commented May 28, 2020

The uri assert required that a hostname and protocol always existed, which may not be true for all URIs.

Thus, when constraints are given, the check is removed.

@nunofgs nunofgs force-pushed the bugfix/accept-constraints-in-uri-assert-without-hostnames-or-protocols branch from ee60168 to 135081f Compare May 29, 2020 11:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@nunofgs