Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sort code passing even though it doesn't exist #10

Open
branks opened this issue Oct 26, 2017 · 2 comments
Open

Sort code passing even though it doesn't exist #10

branks opened this issue Oct 26, 2017 · 2 comments

Comments

@branks
Copy link

branks commented Oct 26, 2017

Sort code : 04-21-13
If you go here - http://www.fasterpayments.org.uk/consumers/sort-code-checker - you can see that the sort code is not valid and does not exist. However it seems to pass all checks with this library

@franciscocardoso
Copy link
Contributor

Hi @branks

From what I can see the sort-code-checker site is only saying No matching sort code found!. Maybe thats because that sort code was not emitted.

Please notice that this module only validates that customer codes and account numbers are compatible.

@branks branks closed this as completed Nov 10, 2017
@branks branks reopened this Nov 10, 2017
@branks
Copy link
Author

branks commented Nov 10, 2017

So building on that, I have found that any account number that uses the sort code of 12-34-56 is a valid combination, is this correct? This seems to make this library quite unusable for validation as 123456 is quite a common dummy sort code

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants