Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hardcoded /tmp/wheel2deb causes problems #62

Open
tbleher opened this issue Feb 2, 2024 · 0 comments
Open

Hardcoded /tmp/wheel2deb causes problems #62

tbleher opened this issue Feb 2, 2024 · 0 comments

Comments

@tbleher
Copy link

tbleher commented Feb 2, 2024

I started using wheel2deb today, and want to first of all say that it is a great tool :)

However, I found one problem: it uses a hardcoded /tmp/wheel2deb folder. This causes two problems:

The first is that it caches information for too long (at least from the point of a new user like me). I built a whl from source, and built a Debian package from it. Then I noticed a wrong dependency in the whl, rebuilt the whl and rebuilt the Debian package. But very surprising for me, the Debian package still had the wrong dependency, even though the whl had the correct dependency. Running strace on wheel2deb I saw that it accessed /tmp/wheel2deb. After removing the folder, the problem went away.

The second problem is that this makes wheel2deb unusable in a multi-user environment, where /tmp is shared between different users. Because after one user has used wheel2deb, another cannot use wheel2deb until /tmp is manually cleaned.

I suggest using temporary directories with unique names, and removing them after wheel2deb has run, in order to avoid these problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant