This repository has been archived by the owner on Aug 15, 2024. It is now read-only.

Params are not URI encoded #205

Open

OliverJAsh opened this issue May 22, 2023 · 1 comment

Member

OliverJAsh commented May 22, 2023 •

edited

Loading

Given:

unsplash.photos.get({ photoId: 'foo/bar' });

Expected: request to /photos/foo%2Fbar
Actual: request to /photos/foo/bar

Note: some usages of getPathname rely on this behaviour:

https://github.com/unsplash/unsplash-web/blob/330bb40640c3e1d3600ecc5a1b15a244013f0c5a/app/services/api/Photo/index.ts#L36C1-L37

The text was updated successfully, but these errors were encountered:

OliverJAsh changed the title ~~Photo ID/slug param is not URI encoded~~ Params are not URI encoded

Member Author

OliverJAsh commented Jul 28, 2023

This most likely affects other endpoints, in addition to /photos.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.