Invoking IApp.Dispose() does not terminate the webdriver

[jeromelaban]

Invoking:

Uno.UITest/src/Uno.UITest.Puppeteer/SeleniumApp.cs

Line 48 in 9669fd2

_driver.Close();

does not terminate the web driver, which can cause issues in multi-build environments.

[jeromelaban]

@ADD-David-Antolin we've been trying to reproduce the issue, but we're unable to when calling App.Dispose(). At this time, the driver is properly closed.

Have you tried invoking this method in the assembly tear down, or test tear down?

[ADD-David-Antolin]

@jeromelaban In TestBase.cs

[Setup]
public void SetupTest()
{
    this.App = AppInitializer.AttachToApp();
}

[TearDown]
public void TearDownTest()
{
    try
    {
        this.TakeScreenShot("teardown");
    }
    finally
    {
        this.App.Dispose();
    }
}

I assume that is test tear down.

[jeromelaban]

@ADD-David-Antolin yes, this is the case. Then if the driver stays active, it may be a bug in selenium or the driver itself. You may need to find a way to determine the PID of the process being launched based on the PTY being used by the build scripts.

Something like this could do, to terminate those processes:

ps -o pid,tty,cmd -ax | grep $(tty) | grep 'msedgedriver' | awk '{print $1}' | xargs kill

[ADD-David-Antolin]

@jeromelaban The agent machines are Windows server so it does not have a tty equivalent I think. Do you know the equivalent of what snippet but for PowerShell?

[jeromelaban]

@ADD-David-Antolin indeed, this technique does not work for Windows. Aside from fixing Selenium, something that is out of our hands at this point. Browsing the source from Selenium may explain why this happens (somewhere in there)

[ADD-David-Antolin]

@jeromelaban I workarounded it in code:

private static void KillMsEdgeDriverProcessWorkaround(IApp app)
{
    if (AppInitializer.GetLocalPlatform() == Platform.Browser
        && typeof(SeleniumApp).GetField("_driver", BindingFlags.Instance | BindingFlags.NonPublic)!.GetValue(app) is EdgeDriver edgeDriver)
    {
        Dictionary<string, object> msedgeEntry = (Dictionary<string, object>)edgeDriver.Capabilities["msedge"];

        string userDataDir = (string)msedgeEntry["userDataDir"];

        string msedgedriverpid = userDataDir[(userDataDir.IndexOf("scoped_dir") + "scoped_dir".Length)..].Split("_")[0];

        app.Dispose();

        Process msedgeDriverProcess = Process.GetProcessById(Convert.ToInt32(msedgedriverpid, CultureInfo.InvariantCulture));

        if (msedgeDriverProcess.ProcessName.Contains("msedgedriver", StringComparison.OrdinalIgnoreCase))
        {
            msedgeDriverProcess.Kill();
        }
    }
}

I tested that this works in Windows machines.

Maybe you can add this somehow to your codebase.