[ToDo][Win/iOS][Settings Flyout] Opening Settings Flyout Changes App Theme Without Interacting with Light/Dark Theme Controls

[agneszitte]

Current behavior

Opening the settings flyout changes the theme of the app without having to click on the Light/Dark theme chips controls in the flyout.

Windows:

341e849f1132fd8f5eb454d20f8fbba6.mp4

iOS:

06ab93685fcbe14cdeab8c15dab1fdae.mp4

Expected behavior

Opening the settings flyout should not change the theme of the app unless the user interacts with the Light/Dark theme chips controls.

How to reproduce it (as minimally and precisely as possible)

• Open the application in Wide Layout.
• Click on the "Get Started" button on the Welcome Page.
• Click on the user name button in the top left corner of the app at the top of the menu to open the settings flyout.
• Observe that the theme of the app changes automatically without clicking on the Light/Dark theme chips controls.
  (Do multiple retries to notice the issue if needed)

Environment

Nuget Package:

• Uno.Sdk: 5.2.161
• UnoExtensionsVersion: 4.1.28
• UnoToolkitVersion: 6.0.24
• UnoThemesVersion: 5.0.13

Affected platform(s):

• Windows
• iOS
• Android
•  WebAssembly

Additional information

Possible related issue: #780

[agneszitte]

@rajamatt / @kazo0
The current logic will need to be reviewed:

Uno.Samples/reference/ToDo/src/ToDo/Views/Dialogs/SettingsFlyout.xaml

Line 107 in af2f226

ItemChecked="ThemeChipGroup_ItemChecked"

Uno.Samples/reference/ToDo/src/ToDo/Views/Dialogs/SettingsFlyout.xaml.cs

Line 37 in af2f226

// Workaround for https://github.com/unoplatform/uno/issues/15287

For Windows every time you open the Settings Flyout you go through here if I am not mistaken:

Uno.Samples/reference/ToDo/src/ToDo/Views/Dialogs/SettingsFlyout.xaml.cs

Line 35 in af2f226

void IRecipient<ThemeChangedMessage>.Receive(ThemeChangedMessage message)