Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Uno.Core] ValidationHelper.IsEmail returns valid for [email protected] while it's not. #61

Open
3 of 11 tasks
alexvlaar opened this issue Oct 30, 2019 · 1 comment
Open
3 of 11 tasks

Comments

@alexvlaar
Copy link

Current behavior

[email protected] is returned as valid by the validation helper.
Method documentation indicates it should validate minimum format of [email protected]

Expected behavior

[email protected] is returned as invalid

How to reproduce it (as minimally and precisely as possible)

var isValid = ValidationHelper.IsEmail("[email protected]");

Environment

Nuget Package:

Package Version(s): 1.29.0-dev.93

Affected platform(s):
Probably all.

  • iOS
  • Android
  • WebAssembly
  • WebAssembly renderers for Xamarin.Forms
  • Windows
  • Build tasks
  • Solution Templates

Visual Studio:

  • 2017 (version: )
  • 2019 (version: )
  • for Mac (version: )

Relevant plugins:

  • Resharper (version: )

Anything else we need to know?

@jeromelaban jeromelaban transferred this issue from unoplatform/uno Oct 30, 2019
@jeromelaban
Copy link
Member

Looks like we're missing unit tests for this:

@"\A(?:[a-z0-9!#$%&'*+/=?^_`{|}~-]+(?:\.[a-z0-9!#$%&'*+/=?^_`{|}~-]+)*@(?:[a-z0-9](?:[a-z0-9-]*[a-z0-9])?\.)+[a-z0-9](?:[a-z0-9-]*[a-z0-9])?)\Z",

Those should help: #62

@alexvlaar could you add you test in this branch ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants