Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(tasks): scheduling tasks for a one-time run in future #2640

Draft
wants to merge 8 commits into
base: v2
Choose a base branch
from

Conversation

elliotjarnit
Copy link

@elliotjarnit elliotjarnit commented Aug 2, 2024

πŸ”— Linked issue

#1974

❓ Type of change

  • πŸ“– Documentation (updates to the documentation, readme, or JSdoc annotations)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • πŸ‘Œ Enhancement (improving an existing functionality like performance)
  • ✨ New feature (a non-breaking change that adds functionality)
  • 🧹 Chore (updates to the build process or auxiliary tools and libraries)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

πŸ“š Description

Provides new functionality to runTask() command, allowing specification of a runAt or runAfter option.

runAt option will delay the running of the task until the Date object (or equivalent string) has passed
runAfter option has the same functionality, except delaying x seconds after the function has been run

πŸ“ Checklist

  • I have linked an issue or discussion.
  • I have updated the documentation accordingly.

@elliotjarnit elliotjarnit marked this pull request as draft August 2, 2024 00:34
@elliotjarnit
Copy link
Author

Still need to update documentation

@elliotjarnit elliotjarnit marked this pull request as ready for review August 2, 2024 01:07
@elliotjarnit
Copy link
Author

Ready for review. Documentation written too.

@franklin-tina
Copy link

Great idea/feature!

@elliotjarnit
Copy link
Author

Can this get a review?

@elliotjarnit
Copy link
Author

@pi0

@pi0
Copy link
Member

pi0 commented Aug 22, 2024

Thanks for the PR dear @elliotjarnit, it looks promising but i have to do more research specially to make sure it will be compatible with different providers.

@pi0 pi0 marked this pull request as draft August 22, 2024 21:26
@pi0 pi0 changed the title feat(tasks): Scheduling tasks for a one-time run in future feat(tasks): scheduling tasks for a one-time run in future Aug 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants