Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add dialect and planetscale connector #59

Merged
merged 7 commits into from
Oct 9, 2024

Conversation

Gerbuuun
Copy link
Contributor

@Gerbuuun Gerbuuun commented Mar 5, 2024

πŸ”— Linked issue

#32

❓ Type of change

  • πŸ“– Documentation (updates to the documentation, readme, or JSdoc annotations)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • πŸ‘Œ Enhancement (improving an existing functionality like performance)
  • ✨ New feature (a non-breaking change that adds functionality)
  • 🧹 Chore (updates to the build process or auxiliary tools and libraries)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

πŸ“š Description

I have added a connector for @planetscale/database.
It is mostly a copy of the Postgresql connector with some small changes.

Due to differences in SQL dialects I added a dialect option to the testConnector function.
Using a switch statement, the correct query is used for the different dialects.
Maybe there are better other options (suggestions)?

πŸ“ Checklist

  • I have linked an issue or discussion.
  • I have updated the documentation accordingly.

Copy link

codecov bot commented Oct 9, 2024

Codecov Report

Attention: Patch coverage is 32.20339% with 40 lines in your changes missing coverage. Please review.

Please upload report for BASE (main@f473e6b). Learn more about missing BASE report.

Files with missing lines Patch % Lines
src/connectors/planetscale.ts 24.00% 38 Missing ⚠️
src/connectors/bun-sqlite.ts 0.00% 1 Missing ⚠️
src/connectors/cloudflare-d1.ts 0.00% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main      #59   +/-   ##
=======================================
  Coverage        ?   42.68%           
=======================================
  Files           ?       16           
  Lines           ?      574           
  Branches        ?       51           
=======================================
  Hits            ?      245           
  Misses          ?      324           
  Partials        ?        5           

β˜” View full report in Codecov by Sentry.
πŸ“’ Have feedback on the report? Share it here.

@pi0 pi0 changed the title feat: add planetscale support feat: add dialect and planetscale connector Oct 9, 2024
Copy link
Member

@pi0 pi0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks ❀️

@pi0 pi0 merged commit ea43ffe into unjs:main Oct 9, 2024
2 checks passed
@pi0 pi0 mentioned this pull request Oct 9, 2024
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants