Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Relax peer dependencies #113

Open
1 task
kingyue737 opened this issue Sep 10, 2024 · 2 comments
Open
1 task

Relax peer dependencies #113

kingyue737 opened this issue Sep 10, 2024 · 2 comments

Comments

@kingyue737
Copy link

Describe the feature

https://github.com/unjs/db0 has not been maintained since its release and the database layer is an experimental feature.
Users always need to override the outdated dependencies of db0. For example:

{
  "pnpm": {
    "peerDependencyRules": {
      "allowedVersions": {
        "db0>drizzle-orm": "^0.33.0"
      }
    },
  },
}

Could we make db0 optional?

Additional information

  • Would you be willing to help implement this feature?
@kingyue737 kingyue737 changed the title Move db0 to optional dependency Make db0 an optional dependency Sep 10, 2024
@pi0 pi0 transferred this issue from unjs/nitro Sep 10, 2024
@pi0
Copy link
Member

pi0 commented Sep 10, 2024

I appreciate the issue. db0 will be eventually a non experimental feature so instead i have moved your issue to db0 repo to see how we can relax db0's peer deps :)

@pi0 pi0 changed the title Make db0 an optional dependency Relax peer dependencies Sep 10, 2024
@backrunner
Copy link

I met an issue that I install a module (@sidebase/nuxt-auth) which depends on nitropack, and the nitropack depends on db0, which will introduce an incorrect version of peer dependency warning into my project. The module is totally not related on anything about database, but it will introduce a totally non-sense version limitation to drizzle-orm, IMO this is not an appropriate behavior.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants