-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: migrate to eslint v9 #150
base: main
Are you sure you want to change the base?
Conversation
Hi @pi0 ! |
eslint.config.mjs
Outdated
import unjs from "eslint-config-unjs"; | ||
|
||
export default unjs({ | ||
ignores: ["dist", "node_modules", "src/_parser.ts", "coverage"], |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm pretty sure dist
and node_modules
are already ignored (otherwise, we should ignore them in the shared config).
coverage
should be ignore in the shared config.
Why ignoring src/_parser.ts
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hello @Barbapapazes , thank you for your comment.
I checked the settings for dist
and coverage
in eslint-config-unjs
. Therefore, I will delete it.
However, with the current settings, node_modules
was not included in this (I don't know why).
src/_parser.ts
was defined in the deleted .eslintignore
.
I don't know why I added it, so I left it as is.
package.json
Outdated
@@ -33,12 +33,12 @@ | |||
"consola": "^3.2.3" | |||
}, | |||
"devDependencies": { | |||
"@types/node": "^20.12.7", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This change is not related to this PR.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
reverted in this commit: 4c0688c
π Linked issue
closed #144 .
β Type of change
π Description
migrated ESLint v9 using eslint-config-unjs
v0.3.2
π Checklist