Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: migrate to eslint v9 #150

Open
wants to merge 5 commits into
base: main
Choose a base branch
from

Conversation

shinGangan
Copy link

πŸ”— Linked issue

closed #144 .

❓ Type of change

  • πŸ“– Documentation (updates to the documentation, readme, or JSdoc annotations)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • πŸ‘Œ Enhancement (improving an existing functionality like performance)
  • ✨ New feature (a non-breaking change that adds functionality)
  • 🧹 Chore (updates to the build process or auxiliary tools and libraries)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

πŸ“š Description

migrated ESLint v9 using eslint-config-unjs v0.3.2

πŸ“ Checklist

  • I have linked an issue or discussion.
  • I have updated the documentation accordingly.

@shinGangan
Copy link
Author

Hi @pi0 !
This PR is low priority, so please review when you have a time πŸ™

import unjs from "eslint-config-unjs";

export default unjs({
ignores: ["dist", "node_modules", "src/_parser.ts", "coverage"],
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm pretty sure dist and node_modules are already ignored (otherwise, we should ignore them in the shared config).

coverage should be ignore in the shared config.

Why ignoring src/_parser.ts.

Copy link
Author

@shinGangan shinGangan Jul 5, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello @Barbapapazes , thank you for your comment.

I checked the settings for dist and coverage in eslint-config-unjs. Therefore, I will delete it.

However, with the current settings, node_modules was not included in this (I don't know why).

src/_parser.ts was defined in the deleted .eslintignore.
I don't know why I added it, so I left it as is.

package.json Outdated
@@ -33,12 +33,12 @@
"consola": "^3.2.3"
},
"devDependencies": {
"@types/node": "^20.12.7",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This change is not related to this PR.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

reverted in this commit: 4c0688c

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants