Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't make a new lsp client for every workspace. #14

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

ChrisPenner
Copy link
Contributor

When writing the original extension I followed the multiple-workspaces example, but since you typically only have a single UCM session open, it doesn't make sense to have multiple LSP clients or servers, and it was leading to the unison lsp commands getting redundantly re-registered in VSCode and throwing errors.

I think this new version is simpler and should avoid those issues. If we really need separate workspaces again in the future I can figure out the proper way to do that, but it doesn't seem necessary right now.

@ChrisPenner ChrisPenner self-assigned this Dec 1, 2023
@aryairani
Copy link
Contributor

Should we merge this? I don't really have enough knowledge to review it, but I can be a rubber duck about it.

@ChrisPenner
Copy link
Contributor Author

This was an attempt to fix the issues that you were encountering specifically, but I'm not sure it solved those and am also not sure anyone else has encountered them 🤔

Maybe try it out? I believe you can just open this repo in vscode and hit F5 to test it.

@aryairani
Copy link
Contributor

This was an attempt to fix the issues that you were encountering specifically, but I'm not sure it solved those and am also not sure anyone else has encountered them 🤔

Maybe try it out? I believe you can just open this repo in vscode and hit F5 to test it.

Cool thanks, I will try.

@aryairani
Copy link
Contributor

aryairani commented Jul 23, 2024

First next steps: Arya to repro his issue on his own. (can try without and with this PR)
Next steps: report findings to Chris.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants