Remove Reference
from StructuredArgument
#5019
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Almost everywhere we produce a
Reference
for numbered args, we also have aHashQualified Name
handy, which is much more consumable by commands.The only case we don’t have an
HQ
is in thetodo
command output, so that now explicitly buildsa
HQ.HashOnly
.This also fixes an issue with
StructuredArgument
handling wherealias.term
and
alias.type
wouldn’t make an alias to aHQ.HashOnly
StructuredArgument
.Fixes #4898.
Test coverage
There is a new transcript to replicate the reported issue.