Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expressions following |> operator should appear on newlines by default #5351

Open
rlmark opened this issue Sep 16, 2024 · 3 comments
Open

Expressions following |> operator should appear on newlines by default #5351

rlmark opened this issue Sep 16, 2024 · 3 comments
Assignees

Comments

@rlmark
Copy link
Contributor

rlmark commented Sep 16, 2024

Describe and demonstrate the bug

@hojberg and I have noticed a change in how terms which include the |> operator are displayed since 0.5.26.

Old display as of 0.5.25:
Screenshot 2024-09-16 at 12 38 24 PM

New display on 0.5.26:
Screenshot 2024-09-16 at 12 38 36 PM

This causes some display issues for the website, where our front page shows some code examples with odd formatting. (We've since decided to deploy with the 0.5.25 executable).

Transcript:
manyOperators.md

Environment (please complete the following information):

  • Version 0.5.26
  • Mac M1 chip
@rlmark rlmark added the bug label Sep 16, 2024
@aryairani
Copy link
Contributor

That is unexpected...

@mitchellwrosen
Copy link
Member

I bisected this (sorry laptop, you can rest now)

c8414eb9cecba34541288c089ac50a604cc9c7d1 is the first bad commit
commit c8414eb9cecba34541288c089ac50a604cc9c7d1
Author: Rúnar <[email protected]>
Date:   Wed Aug 21 00:39:07 2024 -0400

    Simpler infix printer

 .../src/Unison/Syntax/TermPrinter.hs               | 160 ++++++++++-----------
 1 file changed, 79 insertions(+), 81 deletions(-)

@aryairani
Copy link
Contributor

aryairani commented Sep 19, 2024

@runarorama I'm assigning you because I heard you had started on a fix already

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants