Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix a typo in testing.mdx #376

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Conversation

chococandy63
Copy link

I found a typo while going through content/guides/testing.mdx

Copy link
Contributor

@razvand razvand left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks.

Reviewed-by: Razvan Deaconescu [email protected]
Approved-by: Razvan Deaconescu [email protected]

@razvand razvand self-assigned this Mar 2, 2024
Copy link
Member

@StefanJum StefanJum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@chococandy63 do not use merge commits. Use git rebase to rebase your branch on top of main. Also, sign-off your commit (use git commit -s and add a selector to the commit title (something like guides/testing:).

@razvand
Copy link
Contributor

razvand commented Aug 19, 2024

@chococandy63 , could you please see @StefanJum 's comments?

@razvand razvand added the enhancement New feature or request label Aug 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Status: No status
Development

Successfully merging this pull request may close these issues.

3 participants