Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: export ConfigurationResult for reusing #76

Closed
wants to merge 2 commits into from
Closed

chore: export ConfigurationResult for reusing #76

wants to merge 2 commits into from

Conversation

JounQin
Copy link
Member

@JounQin JounQin commented Dec 5, 2023

Initial checklist

  • I read the support docs
  • I read the contributing guide
  • I agree to follow the code of conduct
  • I searched issues and couldn’t find anything (or linked relevant results below)
  • If applicable, I’ve added docs and tests

Description of changes

related https://github.com/mdx-js/eslint-mdx/pull/486/files/88932f183ddbe6f033a794d921fac08427a58ef5#diff-6c1bdf004fec1432e8c27da2092dbb688eccbf3693501fe64a28ab0e3ec4aa28

@github-actions github-actions bot added the 👋 phase/new Post is being triaged automatically label Dec 5, 2023
@JounQin JounQin added ☂️ area/types This affects typings and removed 👋 phase/new Post is being triaged automatically labels Dec 5, 2023
@github-actions github-actions bot added the 🤞 phase/open Post is being triaged manually label Dec 5, 2023
@JounQin
Copy link
Member Author

JounQin commented Dec 5, 2023 •
edited
Loading

image

Weird, I don't think it's related to this PR.

It's thrown by prettier. It seems an unexpected breaking change.

cc @fisker @sosukesuzuki

@fisker
Copy link

fisker commented Dec 5, 2023 •
edited
Loading

Bug in lilconfig, should already fixed in our main branch, https://github.com/antonk52/lilconfig/blob/8deeb3b8e4c4f073e329b29a53781d4f8fc79183/src/index.ts#L217

Test

https://github.com/prettier/prettier/pull/15663/files#diff-b2b9f251d311b100693b2f2d01f0921d0463fa86dfe2e9d74d0efb1c3135675bR184

@JounQin JounQin mentioned this pull request Dec 5, 2023
Merged
@fisker
Copy link

fisker commented Dec 5, 2023

You can add test/fixtures/malformed-package-file/* to .prettierignore

@JounQin
Copy link
Member Author

JounQin commented Dec 5, 2023

You can add test/fixtures/malformed-package-file/* to .prettierignore

I don't think that's what we want, I'm locking prettier@~3.0.0 temporarily.

@wooorm wooorm added the 💪 phase/solved Post is done label Dec 5, 2023
@github-actions github-actions bot removed the 🤞 phase/open Post is being triaged manually label Dec 5, 2023
@wooorm
Copy link
Member

wooorm commented Dec 5, 2023

Thanks!

I added docs, use ConfigResult instead (we also have ConfigTransform already), and I did update the .prettierignore to solve the crash!

@wooorm wooorm closed this in 2aea166 Dec 5, 2023
@github-actions GitHub Actions

This comment was marked as resolved.

Sign in to view
@JounQin JounQin deleted the chore/types branch December 5, 2023 15:16
@wooorm
Copy link
Member

wooorm commented Dec 5, 2023

Thanks, released!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@remcohaszing remcohaszing remcohaszing approved these changes

Assignees
No one assigned
Labels
☂️ area/types This affects typings 💪 phase/solved Post is done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@JounQin @fisker @wooorm @remcohaszing