Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Uplift unvalidate logic to ZeroMap #5660

Open
robertbastian opened this issue Oct 8, 2024 · 0 comments
Open

Uplift unvalidate logic to ZeroMap #5660

robertbastian opened this issue Oct 8, 2024 · 0 comments
Labels
C-zerovec Component: Yoke, ZeroVec, DataBake good first issue Good for newcomers needs-approval One or more stakeholders need to approve proposal S-small Size: One afternoon (small bug fix or enhancement)
Milestone
Utilities 1.0

Comments

@robertbastian
Copy link
Member

Having unvalidated types for ZeroMaps is annoying. We have UnavalidatedTinyAsciiStr, but for struct TimeZoneBcp47Id(TinyAsciiStr<8>) we additionally need struct UnvalidatedTimeZoneBcp47Id(UnvalidatedTinyAsciiStr<8>).

It might be better to have an UnvaliatedZeroMap that doesn't have the iteration methods, and which just skips the key validation internally.
@robertbastian robertbastian added good first issue Good for newcomers S-small Size: One afternoon (small bug fix or enhancement) needs-approval One or more stakeholders need to approve proposal C-zerovec Component: Yoke, ZeroVec, DataBake labels Oct 9, 2024
@robertbastian robertbastian added this to the Utilities 1.0 milestone Oct 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
C-zerovec Component: Yoke, ZeroVec, DataBake good first issue Good for newcomers needs-approval One or more stakeholders need to approve proposal S-small Size: One afternoon (small bug fix or enhancement)
Projects
None yet
Milestone
Utilities 1.0
Development

No branches or pull requests
1 participant
@robertbastian