Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Disentangle the neo datetime datagen #5613

Open
sffc opened this issue Sep 28, 2024 · 0 comments
Open

Disentangle the neo datetime datagen #5613

sffc opened this issue Sep 28, 2024 · 0 comments
Labels
C-datetime Component: datetime, calendars, time zones T-techdebt Type: ICU4X code health and tech debt

Comments

@sffc
Copy link
Member

sffc commented Sep 28, 2024 •
edited
Loading

Currently the neo datetime datagen uses the v1 data structs in order to generate v2 data structs. This was a shortest-path solution at the time to get neo up and off the ground, but now it is tech debt, and we should rewrite v2 datagen to read directly from CLDR-JSON data structs.

Also, make sure the word "name" refers to a localized string and "symbol" refers to the placeholder string. #4328
@sffc sffc added C-datetime Component: datetime, calendars, time zones T-techdebt Type: ICU4X code health and tech debt labels Sep 28, 2024
@sffc sffc mentioned this issue Sep 28, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
C-datetime Component: datetime, calendars, time zones T-techdebt Type: ICU4X code health and tech debt
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@sffc