Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ICU-22962 fix int32_t overflow inside handleComputeJulianDay #3265

Merged

Conversation

FrankYFTang
Copy link
Contributor

@FrankYFTang FrankYFTang commented Nov 8, 2024

Checklist

  • Required: Issue filed: https://unicode-org.atlassian.net/browse/ICU-22962
  • Required: The PR title must be prefixed with a JIRA Issue number. Example: "ICU-1234 Fix xyz"
  • Required: The PR description must include the link to the Jira Issue, for example by completing the URL in the first checklist item
  • Required: Each commit message must be prefixed with a JIRA Issue number. Example: "ICU-1234 Fix xyz"
  • Issue accepted (done by Technical Committee after discussion)
  • Tests included, if applicable
  • API docs and/or User Guide docs changed or added, if applicable

@markusicu markusicu self-assigned this Nov 9, 2024
@FrankYFTang FrankYFTang merged commit 44ea927 into unicode-org:main Nov 9, 2024
94 checks passed
@FrankYFTang FrankYFTang deleted the handleComputeJulianDayOverflow branch November 9, 2024 00:56
@richgillam
Copy link
Contributor

Sorry I didn't get to this in time. The change LGTM.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants