Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ICU-22888 Configure XML processors / external DTDs #3264

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

mihnita
Copy link
Contributor

@mihnita mihnita commented Nov 6, 2024

Checklist

  • Required: Issue filed: https://unicode-org.atlassian.net/browse/ICU-22888
  • Required: The PR title must be prefixed with a JIRA Issue number. Example: "ICU-1234 Fix xyz"
  • Required: The PR description must include the link to the Jira Issue, for example by completing the URL in the first checklist item
  • Required: Each commit message must be prefixed with a JIRA Issue number. Example: "ICU-1234 Fix xyz"
  • Issue accepted (done by Technical Committee after discussion)
  • Tests included, if applicable
  • API docs and/or User Guide docs changed or added, if applicable

Copy link
Member

@markusicu markusicu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks like you meant to make these changes for ICU-22888 not for ICU-22917.

@markusicu markusicu self-assigned this Nov 6, 2024
@jira-pull-request-webhook
Copy link

Hooray! The files in the branch are the same across the force-push. 😃

~ Your Friendly Jira-GitHub PR Checker Bot

@mihnita mihnita changed the title ICU-22917 Configure XML processors / external DTDs ICU-22888 Configure XML processors / external DTDs Nov 6, 2024
@mihnita
Copy link
Contributor Author

mihnita commented Nov 6, 2024

It looks like you meant to make these changes for ICU-22888 not for ICU-22917.

Sorry. Thanks. DONE.

@markusicu
Copy link
Member

@mihnita remember to accept the ticket and merge this PR

@mihnita
Copy link
Contributor Author

mihnita commented Nov 13, 2024

@mihnita remember to accept the ticket and merge this PR

I discovered that there is a PR for this already: #3243

So I reviewed it and waiting for them to update it, so that I can approve it.

I thing it would be good to let them do it.
It is their find, and their fix, not nice to "steal it".
And it might encourage them to contribute again :-)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants