Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update djangolib #3308

Open
wants to merge 2 commits into
base: update-reqs
Choose a base branch
from
Open

update djangolib #3308

wants to merge 2 commits into from

Conversation

domdinicola
Copy link
Contributor

No description provided.

@domdinicola domdinicola force-pushed the djangolib branch 2 times, most recently from c1df29f to bdb3f2f Compare May 31, 2022 11:26
@domdinicola domdinicola changed the base branch from develop to update-reqs May 31, 2022 23:40
@domdinicola domdinicola changed the base branch from update-reqs to develop June 1, 2022 00:07
@domdinicola domdinicola force-pushed the djangolib branch 2 times, most recently from e5cd02e to a008f81 Compare June 1, 2022 07:38
@domdinicola domdinicola changed the base branch from develop to update-reqs June 3, 2022 22:29
@domdinicola domdinicola force-pushed the update-reqs branch 2 times, most recently from 874fa3e to e26a309 Compare June 4, 2022 01:58
@domdinicola domdinicola changed the title update reqs update djangolib Jun 4, 2022
@domdinicola
Copy link
Contributor Author

domdinicola commented Jun 4, 2022

@roman-karpovich can you please check the PR? tests are failing due unicef/unicef-djangolib#6

@roman-karpovich
Copy link
Collaborator

@roman-karpovich can you please check the PR? tests are failing due unicef/unicef-djangolib#6

done

@@ -117,6 +117,7 @@ def get_from_secrets_or_env(var_name, default=None):

# DJANGO: HTTP
MIDDLEWARE = (
'unicef_djangolib.middleware.HealthCheckMiddleware',
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why are we updating middleware, whats the point of this?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants