From f195484674efcff4a1ab27107ad0d2579645f85c Mon Sep 17 00:00:00 2001 From: Tim Donohue Date: Thu, 11 Jul 2024 14:57:25 -0500 Subject: [PATCH] Update pull_request_template.md Add note that PRs should be against main, if possible. --- .github/pull_request_template.md | 1 + 1 file changed, 1 insertion(+) diff --git a/.github/pull_request_template.md b/.github/pull_request_template.md index b381944c98f..39d5b191d63 100644 --- a/.github/pull_request_template.md +++ b/.github/pull_request_template.md @@ -19,6 +19,7 @@ List of changes in this PR: _This checklist provides a reminder of what we are going to look for when reviewing your PR. You need not complete this checklist prior to creating your PR (draft PRs are always welcome). However, reviewers may request that you complete any actions in this list if you have not done so. If you are unsure about an item in the checklist, don't hesitate to ask. We're here to help!_ +- [ ] My PR is **created against the `main` branch** of code (unless it is a backport or is fixing an issue specific to an older branch). - [ ] My PR is **small in size** (e.g. less than 1,000 lines of code, not including comments & specs/tests), or I have provided reasons as to why that's not possible. - [ ] My PR **passes [ESLint](https://eslint.org/)** validation using `yarn lint` - [ ] My PR **doesn't introduce circular dependencies** (verified via `yarn check-circ-deps`)