-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Handle serialization/loading of ConfigHolder with missing values #25
Comments
This isn't causing any problems currently because during dataset creation we don't use I'm not really sure what our long-term plans are with configs and |
If we aren't currently using |
Sounds reasonable. In that case the only TODO for this ticket would be to delete the test that @rusheb linked. |
I haven't had any issues with this for a while, despite several changes to the |
If ConfigHolder has missing values it will fail to serialize, as demonstrated in test_serialize_and_load_missing_values.
This might be an issue if we don't have all the configs, e.g. at the dataset creation stage.
However maybe at that point we wouldn't serialize the entire config. I'm not sure what the best behaviour should be
The text was updated successfully, but these errors were encountered: