Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expose emptyClick event on GraferController #57

Open
DSheffield opened this issue Jan 10, 2023 · 0 comments
Open

Expose emptyClick event on GraferController #57

DSheffield opened this issue Jan 10, 2023 · 0 comments

Comments

@DSheffield
Copy link
Collaborator

Presently you cannot subscribe to the 'emptyClick' event directly from the GraferController, as with other events (hover, hoverOff, click). Rather you have to dig deep in the controller internals, e.g.:

controller.viewport.graph.picking.on(UX.picking.PickingManager.events.emptyClick, someCallback))

This is not very clear / obvious. Would be simpler and more congruent with other events to do so directly from the controller:

controller.on(UX.picking.PickingManager.events.emptyClick, this.onBackgroundClick.bind(this));

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant