[BUG] Editing default member type doesn't work when over 500 members exist

[nymwo]

Which Umbraco version are you using? (Please write the exact version, example: 10.1.0)

14.2.0

Bug summary

When having over 500 members, editing and saving the default member type fails and generates an error. The error indicates that RefreshMemberOfMemberTypes calls MemberService.GetAll with an invalid skip value.

Specifics

The exception:

An unhandled exception has occurred while executing the request.
System.AggregateException: One or more errors occurred. (Invalid skip/take, Skip must be a multiple of take - i.e. skip = 10, take = 5)
 ---> System.ArgumentException: Invalid skip/take, Skip must be a multiple of take - i.e. skip = 10, take = 5
   at Umbraco.Cms.Core.PaginationHelper.ConvertSkipTakeToPaging(Int32 skip, Int32 take, Int64& pageNumber, Int32& pageSize)
   at Umbraco.Cms.Core.Services.IMemberService.GetAll(Int32 skip, Int32 take, Int64& totalRecords, String orderBy, Direction orderDirection, String memberTypeAlias, String filter)
   at Umbraco.Cms.Infrastructure.Search.ContentTypeIndexingNotificationHandler.RefreshMemberOfMemberTypes(Int32[] memberTypeIds)
   at Umbraco.Cms.Infrastructure.Search.ContentTypeIndexingNotificationHandler.Handle(ContentTypeCacheRefresherNotification args)
   at Umbraco.Cms.Core.Events.INotificationHandler`1.Handle(IEnumerable`1 notifications)
   at Umbraco.Cms.Core.Events.EventAggregator.PublishCore[TNotification](IEnumerable`1 allHandlers, IEnumerable`1 notifications)
   at Umbraco.Cms.Core.Events.NotificationHandlerWrapperImpl`1.Handle[TNotification,TNotificationHandler](IEnumerable`1 notifications, ServiceFactory serviceFactory, Action`2 publish)
   at Umbraco.Cms.Core.Events.EventAggregator.PublishNotifications[TNotification,TNotificationHandler](IEnumerable`1 notifications)
   at Umbraco.Cms.Core.Events.EventAggregator.Publish[TNotification,TNotificationHandler](IEnumerable`1 notifications)
   at Umbraco.Cms.Core.Events.EventAggregator.Publish[TNotification](TNotification notification)
   at Umbraco.Cms.Core.Cache.CacheRefresherBase`1.OnCacheUpdated(CacheRefresherNotification notification)
   at Umbraco.Cms.Core.Cache.PayloadCacheRefresherBase`2.Refresh(TPayload[] payloads)
   at Umbraco.Cms.Core.Cache.ContentTypeCacheRefresher.Refresh(JsonPayload[] payloads)
   at Umbraco.Cms.Infrastructure.Sync.ServerMessengerBase.DeliverLocal[TPayload](ICacheRefresher refresher, TPayload[] payload)
   at Umbraco.Cms.Infrastructure.Sync.ServerMessengerBase.Deliver[TPayload](ICacheRefresher refresher, TPayload[] payload)
   at Umbraco.Cms.Infrastructure.Sync.ServerMessengerBase.QueueRefresh[TPayload](ICacheRefresher refresher, TPayload[] payload)

Steps to reproduce

1. Have over 500 members
2. Try to edit and save the member type "Member" in Backoffice

Expected result / actual result

No response

[github-actions]

Hi there @nymwo!

Firstly, a big thank you for raising this issue. Every piece of feedback we receive helps us to make Umbraco better.

We really appreciate your patience while we wait for our team to have a look at this but we wanted to let you know that we see this and share with you the plan for what comes next.

• We'll assess whether this issue relates to something that has already been fixed in a later version of the release that it has been raised for.
• If it's a bug, is it related to a release that we are actively supporting or is it related to a release that's in the end-of-life or security-only phase?
• We'll replicate the issue to ensure that the problem is as described.
• We'll decide whether the behavior is an issue or if the behavior is intended.

We wish we could work with everyone directly and assess your issue immediately but we're in the fortunate position of having lots of contributions to work with and only a few humans who are able to do it. We are making progress though and in the meantime, we will keep you in the loop and let you know when we have any questions.

Thanks, from your friendly Umbraco GitHub bot 🤖 🙂