Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Readonly Color Picker Property Editor UI #17045

Closed
madsrasmussen opened this issue Sep 11, 2024 · 0 comments · Fixed by umbraco/Umbraco.CMS.Backoffice#2451
Closed

Readonly Color Picker Property Editor UI #17045

madsrasmussen opened this issue Sep 11, 2024 · 0 comments · Fixed by umbraco/Umbraco.CMS.Backoffice#2451

Comments

@madsrasmussen
Copy link
Contributor

Which Umbraco version are you using? (Please write the exact version, example: 10.1.0)

14.2

Bug summary

Implement the read-only mode of the Color Picker Property Editor UI.

Specifics

Here is a link to a PR that implements read-only mode for another Property Editor UI.
umbraco/Umbraco.CMS.Backoffice#2220

Prerequisites
umbraco/Umbraco.UI#898
umbraco/Umbraco.UI#899
umbraco/Umbraco.UI#900
umbraco/Umbraco.UI#901
umbraco/Umbraco.UI#902

Steps to reproduce

Add the readonly attribute to the element through developer tools

Expected result / actual result

It is possible to interact and readonly the property editor values but not update them.

richarth added a commit to richarth/Umbraco.CMS.Backoffice that referenced this issue Oct 12, 2024
Implemented the read-only mode of the Color Picker Property Editor UI to close umbraco/Umbraco-CMS#17045.
iOvergaard added a commit to umbraco/Umbraco.CMS.Backoffice that referenced this issue Oct 14, 2024
* Adds read-only mode to Color Picker Property Editor

Implemented the read-only mode of the Color Picker Property Editor UI to close umbraco/Umbraco-CMS#17045.

* feat: forward the `readonly` attribute to the swatch* elements

* chore: rearrange properties in the element

---------

Co-authored-by: Jacob Overgaard <[email protected]>
iOvergaard added a commit that referenced this issue Nov 9, 2024
* Adds read-only mode to Color Picker Property Editor

Implemented the read-only mode of the Color Picker Property Editor UI to close #17045.

* feat: forward the `readonly` attribute to the swatch* elements

* chore: rearrange properties in the element

---------

Co-authored-by: Jacob Overgaard <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant