Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Should the VPP response headers include etag too? #108

Open
Shazwazza opened this issue Jun 13, 2018 · 2 comments
Open

Should the VPP response headers include etag too? #108

Shazwazza opened this issue Jun 13, 2018 · 2 comments
Labels
question

Comments

@Shazwazza
Copy link
Contributor

The resulting cache headers are set here https://github.com/JimBobSquarePants/UmbracoFileSystemProviders.Azure/blob/develop/src/UmbracoFileSystemProviders.Azure/FileSystemVirtualFile.cs#L61

but should etag be included too?
@JimBobSquarePants
Copy link
Contributor

Probably yes. It would be nice If we were able to set all the headers without having to hack like this though.

@JimBobSquarePants JimBobSquarePants mentioned this issue Jan 16, 2019
Merged
@JimBobSquarePants
Copy link
Contributor

Rethinking this somewhat. The way we set heads is a total hack and depends on the VPP being enabled. There should be a better way in Umbraco.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
question
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@JimBobSquarePants @Shazwazza