Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ability to isolate a layer #2097

Closed
pfbreton-perso opened this issue Sep 3, 2024 · 14 comments · Fixed by #2160
Closed

Ability to isolate a layer #2097

pfbreton-perso opened this issue Sep 3, 2024 · 14 comments · Fixed by #2160

Comments

@pfbreton-perso
Copy link
Contributor

Is your feature request related to a problem? Please describe.
I have a map where I collect many GPX files uploaded from various sources. After a few years, I ended up with over 100 layers. I would like to be able to quickly isolate a layer for inspection, download etc.

Describe the solution you'd like
A series of contextual commands that let me manage the visibility of multiple layers at a time would get ideal:

minimally, 2 commands that let me hide or show all layers would work:

  • show all layers
  • hide all alyers
    (then I can unhide the layer of my choice)

Describe alternatives you've considered
another approach could be to have a command entitled:

  • toggle visibility of selected layer(s) , assuming that layer selection is something possible

Additional context
Here is the type of map that I use where I would find this feature useful:

image

@pfbreton-perso
Copy link
Contributor Author

note: I discovered the filter feature after writing this down. this is an acceptable workaround, although more difficult to discover

@yohanboniface
Copy link
Member

@Aurelie-Jallut where could we add a "show/hide all" button ? :)

@Aurelie-Jallut
Copy link
Contributor

Something like that ? :
image

@yohanboniface
Copy link
Member

Would work for sure! Is there a way not to consume vertical space you think ? :)

@Aurelie-Jallut
Copy link
Contributor

Aurelie-Jallut commented Sep 5, 2024

image

@Aurelie-Jallut
Copy link
Contributor

Aurelie-Jallut commented Sep 5, 2024

image

@harzguide
Copy link

Hello everyone, I have the same problem. I am currently working on a map project ‘Braunschweiger Jacobsweg’ with a large number of POI, churches, stamp points, catering facilities, public transport stops etc. My idea is to add another selection option in the form of small square windows. (The ‘eyes´ control the visibility, the boxes control the selection, for example for data export. This would give us a quick way of editing.
Possible commands for the selection:
Select All Layers, Clear Selection, Custom Selection.
Such an option would also help me, especially with complex projects.
Best regards, Burkhard

Translated with www.DeepL.com/Translator (free version)

@harzguide
Copy link

je suis désolé !
j'ai oublié de me présenter brièvement :
Je m'appelle Burkhard (harzguide) et je m'intéresse depuis des années à la randonnée avec les transports en commun. Depuis l'année dernière, j'ai changé de mode de transport pour plusieurs de ces randonnées, car c'est pour moi la meilleure option. Une série de problèmes et de questions sont apparus, dont j'aimerais discuter avec vous ou participer à la résolution.
Amitiés, Burkhard

je suis désolé !
j'ai oublié de me présenter brièvement :
Je m'appelle Burkhard (harzguide) et je m'intéresse depuis des années à la randonnée avec les transports en commun. Depuis l'année dernière, j'ai changé de mode de transport pour plusieurs de ces randonnées, car c'est pour moi la meilleure option. Une série de problèmes et de questions sont apparus, dont j'aimerais discuter avec vous ou participer à la résolution.
Amitiés, Burkhard
Traduit avec www.DeepL.com/Translator (version gratuite)

Excuse me,
I forgot to introduce myself briefly:
My name is Burkhard (harzguide) and I have been involved with the topic of ‘hiking with public transport’ for years. Since last year, I've switched a number of these hikes to walking as it's the best option for me. A number of problems and questions have arisen that I would like to discuss with you or help to solve.
Best regards, Burkhard

@harzguide
Copy link

Correction
Since last year, I have switched a number of these hikes to umap, as it is the best option for me.

@harzguide
Copy link

Hello everyone,
I have just tried the ‘Filter’ method. This works to the extent that you can isolate a single layer and then edit it - but it doesn't hide the layers you don't want. The problem is, however, that if I want to export only this layer, e.g. to insert it into another map, this does not work. All layers are exported.
That's why I think it's better to implement the solution I suggested. On the one hand, it allows me to edit only the layer that I want, but at the same time to select the layer that I want to import into another map. I think that this way we can enable more comprehensive editing.
Kind regards,Burkhard

Bonjour à tous !
Je viens d'essayer la méthode « filtre ». Cela fonctionne dans la mesure où l'on peut isoler un seul calque et le modifier ensuite - mais les calques non souhaités ne sont pas masqués. Le problème, c'est que si je veux exporter ce calque pour l'insérer dans une autre carte par exemple, cela ne fonctionne pas. Tous les calques sont exportés.
C'est pourquoi je pense qu'il est préférable de mettre en œuvre la solution que j'ai proposée. Elle permet d'une part de ne modifier que le calque que je veux, mais aussi de sélectionner le calque que je veux importer dans une autre carte. Je pense que nous pouvons ainsi permettre un traitement plus complet.
Amitiés, Burkhard

Traduit avec www.DeepL.com/Translator (version gratuite)

Translated with www.DeepL.com/Translator (free version)

@pfbreton-perso
Copy link
Contributor Author

This is a good point. I forgot to mention that one of the motivation to isolate elements on the map is to export after. I agree with you that the export should probably allow for a WYSIWYG where hidden elements do not export.

@yohanboniface
Copy link
Member

The export should be WYSIWYG, and if not it's a bug.

To export only one layer, one can edit it and click on "download" on "advanced actions". We may add a "download" icon within the quick action (close to the magnifying glass, eye…) to make it simpler, but this toolbox is not extensive to infinite…

@harzguide
Copy link

Hello Yohan,
Thanks for your reply. Exporting as WYSIWYG is not a problem, it works fine as a geojosn file
Regarding the selection of layers to be exported:
It's not just about exporting a single layer, but also having the option of selecting a group of layers. I have already written that I am working on a project called ‘Braunschweiger Jacobsweg’. This involves a large amount of data in the form of markers, which are stored with information (links, text modules). I have compiled all these markers as individual layers in separate maps in order to transfer them later to a new hiking map (stage). Currently, to do this, I often have to make a large number of layers invisible (eye) in order to select a small number of layers for export. It would be easier if I could go the other way round and select only a few layers from a large number. Hence my suggestion to insert an additional selection bar (box) in the layer window. Result: I click on the few layers I need, export them to the desktop and then import them as a group (restaurants, churches, museums, etc.) into the corresponding tour map and the job would be done, much easier and faster.
Thanks again, best regards, Burkhard

Translated with www.DeepL.com/Translator (free version)

@harzguide
Copy link

Hello,
I would like to show you one or the other card, but I don't know how to do it. Is it enough to copy the links and send them as a comment?
Burkhard

yohanboniface added a commit that referenced this issue Sep 23, 2024
yohanboniface added a commit that referenced this issue Oct 16, 2024
fix #2097
cf #1500


![image](https://github.com/user-attachments/assets/2c8b96e4-8cf7-4d5f-afed-11adf73e98a8)

This is an alternative proposal for #2097:

- adding the button near the "Filter" toggle was a bit ugly, CSS/HTML
talking, because this "Filters" box is a details/summary
- I thought that other needs could live in the same place: a link to
download the filtered/visible data, and a button to show the map data
extent

The "toggle all" button works this way:
- if one or more layers are shown, it will hide those layers
- otherwise it will show all layers

I've preferred not to change the button icon according to map state,
because I didn't find a reliable way to do so, thus I'm afraid to have
inconsistency, but I can't try harder if needed.

Related: I'm thinking of adding a "Download" button for each layers, as
it's a request that comes quite often.

@Aurelie-Jallut could you have a look ? :)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants