Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug/Documentation] Old and new game states report same step #28

Open
OoJJBoO opened this issue Sep 14, 2023 · 0 comments
Open

[Bug/Documentation] Old and new game states report same step #28

OoJJBoO opened this issue Sep 14, 2023 · 0 comments

Comments

@OoJJBoO
Copy link

OoJJBoO commented Sep 14, 2023

We noticed that the old_game_state and new_game_state dictionaries that are passed to the game_events_occurred agent callbacks contain the same "step" value.

This seems to not always having been the case, as we found that this behavior was first introduced in commit 35b4965. The issue is caused by the agent state being stored here after the step was already incremented here.

Is this intended behavior? If so, we would suggest updating the documentation to communicate this more clearly to prevent misunderstandings in the future.

For instance, our team tried to use the stored step to retrieve cached data, which of course did not work as we had intended because of the way step reporting is handled at the moment.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant