Fixing user agent handling bug

uilicious · Jun 8, 2022 · eab3bd8 · eab3bd8
1 parent d96f800
commit eab3bd8
Show file tree

Hide file tree

Showing 2 changed files with 13 additions and 6 deletions.
diff --git a/src/api/SpaceAndProjectApi.js b/src/api/SpaceAndProjectApi.js
@@ -301,6 +301,9 @@ class SpaceAndProjectApi {
 			height: height,
 			cli: 1
 		};
+		if( testParams.userAgent != null && testParams.userAgent.length >= 1 ) {
+			reqObj.userAgent = testParams.userAgent;
+		}
 		if( dataSetID != null ) {
 			reqObj["environmentId"] = dataSetID;
 		} else {

diff --git a/src/cli-command/project/run.js b/src/cli-command/project/run.js
@@ -158,6 +158,7 @@ class TestRunnerSession {
 
 		// Script path and browser settings
 		let scriptPath = argv["script-path"];
+		let userAgent  = argv.userAgent || null;
 		let browser = argv.browser || "chrome";
 		let width   = argv.width   || 1280;
 		let height  = argv.height  || 960;
@@ -215,6 +216,7 @@ class TestRunnerSession {
 		this.height            = height;
 		this.region            = region;
 		this.dataSet           = dataSet;
+		this.userAgent         = userAgent;
 		this.startTimeout      = startTimeout;
 		this.startTimeout_sec  = startTimeout_sec;
 		this.startTimeout_ms   = startTimeout_ms;
@@ -259,6 +261,12 @@ class TestRunnerSession {
 				`> Test Dir:     ${this.testCodeDir}`
 			)
 		}
+		// Custom UA
+		if( this.userAgent != null ) {
+			OutputHandler.standardGreen(
+				`> User Agent:   ${this.userAgent}`
+			)
+		}
 		OutputHandler.standardGreen(">")
 	}
 
@@ -331,13 +339,9 @@ class TestRunnerSession {
 				region:     this.region,
 				dataSetID:  this.dataSetID,
 				data:       this.dataObject,
-				secretData: this.secretObject
+				secretData: this.secretObject,
+				userAgent:  this.userAgent
 			};
-
-			// User agent support
-			if( this.userAgent != null && this.userAgent != "" && this.userAgent.length > 2 ) {
-				startRequestParams.userAgent = this.userAgent;
-			}
 
 			// Start the test
 			let result = await SpaceAndProjectApi.startProjectTest( //