consistent namelist cires_ugwp_nml for ugwpv0 and ugwpv1

[junwang-noaa]

Description

Both ugwpv0 and ugwpv1 are using the same namelist cires_ugwp_nml, but they define the namelist in their own subroutines cires_ugwp_module.F90 and cires_ugwpv1_module.F90. The same namelist contains different variables, which causes confusions and issues in up level configurations/templates/script that need to test the two ugwp schemes. E.g. lauch_level is a namelist variable for ugwpv0, but is a hardcoded variable for ugwpv1. The possible solutions are:

1. only define one namelist cires_upwp_nml, and this namelist will be used by both ugwp schemes.
2. ugwpv0 and ugwpv1 define their own namelist with different namelist names.

The impact to top level namelist template can be seen in UFS weather model PR#1965:
ufs-community/ufs-weather-model#1941 (comment)

which is confusing and error-prone.

Steps to Reproduce

Please provide detailed steps for reproducing the issue.

1. namleist in ugwpv0:
   

   ccpp-physics/physics/cires_ugwp_module.F90

   Line 56 in c2ec9e5

   namelist /cires_ugwp_nml/ knob_ugwp_solver, knob_ugwp_source,knob_ugwp_wvspec, knob_ugwp_azdir, &

2. namelist in ugwpv1:
   

   ccpp-physics/physics/cires_ugwpv1_module.F90

   Line 90 in c2ec9e5

   namelist /cires_ugwp_nml/ knob_ugwp_solver, knob_ugwp_source,knob_ugwp_wvspec, knob_ugwp_azdir, &

3. seeing differences between 1) and 2).

Additional Context

Please provide any relevant information about your setup. This is important in case the issue is not reproducible except for under certain conditions.

• Machine
• Compiler
• Suite Definition File or Scheme
• Reference other issues or PRs in other repositories that this is related to, and how they are related.

Output

Please include any relevant log files, screenshots or other output here.

[SamuelTrahanNOAA]

I prefer option 1. Make a new cires_ugwp_namelist.F90 and have it read the namelist. Any ugwp schemes use that module to read namelists.

[junwang-noaa]

@mdtoyNOAA @yangfanglin @Qingfu-Liu FYI.

[lisa-bengtsson]

I'm preparing a PR to the global workflow HR3 tag with the convection namelist changes, will commit to Jessica Mexiner's HR3 working branch once this is merged.