diff --git a/CONTRIBUTING.md b/CONTRIBUTING.md index 5a7ab416a0..e59b86f408 100644 --- a/CONTRIBUTING.md +++ b/CONTRIBUTING.md @@ -36,7 +36,7 @@ Before submitting a pull request: - Check the codebase to ensure that your feature doesn't already exist. - Check the pull requests to ensure that another person hasn't already submitted the feature or fix. -Before commiting: +Before committing: - Make sure to run the tests and linter before committing your changes. - If you are making changes to one of the packages, make sure to **always** include a [changeset](https://github.com/changesets/changesets) in your PR describing **what changed** with a **description** of the change. Those are responsible for changelog creation diff --git a/demos/src/Examples/Transition/Vue/index.spec.js b/demos/src/Examples/Transition/Vue/index.spec.js index 5bceb87e19..39100317df 100644 --- a/demos/src/Examples/Transition/Vue/index.spec.js +++ b/demos/src/Examples/Transition/Vue/index.spec.js @@ -3,26 +3,30 @@ context('/src/Examples/Transition/Vue/', () => { cy.visit('/src/Examples/Transition/Vue/') }) - it('should not have an active tiptap instance but a button', () => { + it('should have two buttons and no active tiptap instance', () => { cy.get('.tiptap').should('not.exist') - cy.get('#toggle-editor').should('exist') + cy.get('#toggle-direct-editor').should('exist') + cy.get('#toggle-nested-editor').should('exist') }) - it('clicking the button should show the editor', () => { - cy.get('#toggle-editor').click() + it('clicking the buttons should show two editors', () => { + cy.get('#toggle-direct-editor').click() + cy.get('#toggle-nested-editor').click() cy.get('.tiptap').should('exist') cy.get('.tiptap').should('be.visible') }) - it('clicking the button again should hide the editor', () => { - cy.get('#toggle-editor').click() + it('clicking the buttons again should hide the editors', () => { + cy.get('#toggle-direct-editor').click() + cy.get('#toggle-nested-editor').click() cy.get('.tiptap').should('exist') cy.get('.tiptap').should('be.visible') - cy.get('#toggle-editor').click() + cy.get('#toggle-direct-editor').click() + cy.get('#toggle-nested-editor').click() cy.get('.tiptap').should('not.exist') }) diff --git a/demos/src/Examples/Transition/Vue/index.vue b/demos/src/Examples/Transition/Vue/index.vue index 74cfa294c5..6bd914949b 100644 --- a/demos/src/Examples/Transition/Vue/index.vue +++ b/demos/src/Examples/Transition/Vue/index.vue @@ -40,10 +40,10 @@ const editor = useEditor({