Updated reflective finding of declared vals in Bundles. #181
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Conflicts: src/main/scala/Backend.scala src/main/scala/Module.scala
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A while ago, I added a check that elaborates the declared fields of a class and examines whether methods share names with fields to determine whether they are
valaccessors or not (along with other checks, like arity).This made parameter-less methods returning instances of
Datawork inside modules, but issue #179 brings up the problem that this won't work in aBundle. The branch here fixes this issue by performing the new check forvalaccessors inBundleinstances. In order to reduce the redundant code, I thought it might be a good idea to factor out the generation of a list of methods categorized asvalaccessors into another object's method.