From 660f0ad9e8040afc129a5c76c591280b0206cad1 Mon Sep 17 00:00:00 2001 From: ucan-lab <35098175+ucan-lab@users.noreply.github.com> Date: Tue, 7 May 2024 21:56:52 +0900 Subject: [PATCH 1/3] chore: Add Hadolint GitHub Actions Workflow --- .github/workflows/testing-pull-request.yaml | 3 +++ 1 file changed, 3 insertions(+) diff --git a/.github/workflows/testing-pull-request.yaml b/.github/workflows/testing-pull-request.yaml index 678ffff..68f2aa6 100644 --- a/.github/workflows/testing-pull-request.yaml +++ b/.github/workflows/testing-pull-request.yaml @@ -36,6 +36,9 @@ jobs: - uses: actions/checkout@v4 with: fetch-depth: 0 + - uses: hadolint/hadolint-action@v3.1.0 + with: + recursive: true - name: Docker Version run: docker version - name: Docker Compose Settings From 080f55dc39fd7ecfbf5c289f155f22687fae7446 Mon Sep 17 00:00:00 2001 From: ucan-lab <35098175+ucan-lab@users.noreply.github.com> Date: Tue, 7 May 2024 23:07:49 +0900 Subject: [PATCH 2/3] chore: DL3008 warning: Pin versions in apt get install. Instead of `apt-get install ` use `apt-get install =` --- infra/docker/php/Dockerfile | 14 +++++++------- 1 file changed, 7 insertions(+), 7 deletions(-) diff --git a/infra/docker/php/Dockerfile b/infra/docker/php/Dockerfile index 63e1a1d..2be4ec0 100644 --- a/infra/docker/php/Dockerfile +++ b/infra/docker/php/Dockerfile @@ -19,13 +19,13 @@ COPY --from=composer:2.7 /usr/bin/composer /usr/bin/composer RUN < Date: Tue, 7 May 2024 23:08:34 +0900 Subject: [PATCH 3/3] chore: DL3009 info: Delete the apt-get lists after installing something --- infra/docker/php/Dockerfile | 14 ++------------ 1 file changed, 2 insertions(+), 12 deletions(-) diff --git a/infra/docker/php/Dockerfile b/infra/docker/php/Dockerfile index 2be4ec0..499b527 100644 --- a/infra/docker/php/Dockerfile +++ b/infra/docker/php/Dockerfile @@ -41,15 +41,12 @@ RUN <