Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Core: fix step run error logging #2828

Open
amartinz opened this issue Sep 7, 2022 · 0 comments
Open

Core: fix step run error logging #2828

amartinz opened this issue Sep 7, 2022 · 0 comments

Comments

@amartinz
Copy link
Member

amartinz commented Sep 7, 2022

Eh, looks like Winston's default error object handling is just too simple. For an error that apparently kills the run, everything including the stacktrace should be printed and JSON.stringify won't work since the properties are not enumerable.

This looks like the simplest solution: winstonjs/winston#1338 (comment)
Would require also changing this to two log calls (also this feels more like error than debug level imo).

Originally posted by @maciek134 in #2827 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant