Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unit tests for virtual cards backend #271

Closed
EresDev opened this issue Aug 2, 2024 · 16 comments · Fixed by #351
Closed

Unit tests for virtual cards backend #271

EresDev opened this issue Aug 2, 2024 · 16 comments · Fixed by #351

Comments

@EresDev
Copy link
Contributor

EresDev commented Aug 2, 2024

The tests with this repository are e2e tests. That's how I started the virtual cards feature and used e2e tests.
As the feature is getting refined, I think it would be good idea to bring in unit tests for the backend functions. Cloudflare recommends vitest because backend functions are Cloudflare pages function. Along with the general advantages of unit tests over e2e tests, I see following reasons to have them.

  • These tests will mock Reloadly, which e2e is not doing and the recent problem with their API slowed our progress.
  • Testing edge cases for the security of order placement will be easier
Copy link

ubiquibot bot commented Aug 2, 2024

@EresDev, You are not allowed to add Time: <1 Week

Copy link

ubiquibot bot commented Aug 2, 2024

! No permission to set labels

@hydroxylase
Copy link
Contributor

/start

Copy link

ubiquibot-dev bot commented Aug 8, 2024

! Please set your wallet address with the /wallet command first and try again.

@hydroxylase
Copy link
Contributor

/wallet 0x229674f3db146E0AF0182b660F5c9232538E7e7b

Copy link

ubiquibot-dev bot commented Aug 8, 2024

+ Successfully registered wallet address

Copy link

ubiquibot bot commented Aug 8, 2024

+ Successfully registered wallet address

@hydroxylase
Copy link
Contributor

/start

Copy link

ubiquibot-dev bot commented Aug 8, 2024

DeadlineThu, Aug 15, 9:00 AM UTC
Registered Wallet 0x229674f3db146E0AF0182b660F5c9232538E7e7b
Tips:
  • Use /wallet 0x0000...0000 if you want to update your registered payment wallet address.
  • Be sure to open a draft pull request as soon as possible to communicate updates on your progress.
  • Be sure to provide timely updates to us when requested, or you will be automatically unassigned from the task.

Copy link

ubiquibot bot commented Aug 8, 2024

DeadlineThu, Aug 15, 9:00 AM UTC
Registered Wallet 0x229674f3db146E0AF0182b660F5c9232538E7e7b
Tips:
  • Use /wallet 0x0000...0000 if you want to update your registered payment wallet address.
  • Be sure to open a draft pull request as soon as possible to communicate updates on your progress.
  • Be sure to provide timely updates to us when requested, or you will be automatically unassigned from the task.

Copy link

ubiquibot bot commented Aug 16, 2024

# No linked pull requests to close

@pbkompasz
Copy link
Contributor

/start

Copy link
Contributor

ubiquity-os bot commented Aug 22, 2024

DeadlineThu, Aug 29, 8:25 PM UTC
Registered Wallet 0x26BfbD8ED2B302ec2c2B6f063C4caF7abcB062e0
Tips:
  • Use /wallet 0x0000...0000 if you want to update your registered payment wallet address.
  • Be sure to open a draft pull request as soon as possible to communicate updates on your progress.
  • Be sure to provide timely updates to us when requested, or you will be automatically unassigned from the task.

@EresDev
Copy link
Contributor Author

EresDev commented Oct 22, 2024

/start

Copy link
Contributor

ubiquity-os bot commented Oct 22, 2024

Warning! This task was created over 80 days ago. Please confirm that this issue specification is accurate before starting.
Deadline Tue, Oct 29, 8:11 AM UTC
Beneficiary 0xE7a9fdf596D869AF34a130fa9607178B2B9800D9

Tip

  • Use /wallet 0x0000...0000 if you want to update your registered payment wallet address.
  • Be sure to open a draft pull request as soon as possible to communicate updates on your progress.
  • Be sure to provide timely updates to us when requested, or you will be automatically unassigned from the task.

Copy link
Contributor

ubiquity-os bot commented Nov 8, 2024

 [ 836.42 UUSD ] 

@EresDev
Contributions Overview
ViewContributionCountReward
IssueTask1800
IssueSpecification136.42
ReviewComment10
Conversation Incentives
CommentFormattingRelevanceReward
The tests with this repository are e2e tests. That's how I start…
12.14
content:
  content:
    p:
      score: 0
      elementCount: 4
    a:
      score: 5
      elementCount: 1
    ul:
      score: 1
      elementCount: 1
    li:
      score: 0.5
      elementCount: 2
  result: 7
regex:
  wordCount: 103
  wordValue: 0.1
  result: 5.14
136.42
Resolves #271With unit tests, it also includes some renaming a…
4.5
content:
  content:
    p:
      score: 0
      elementCount: 5
    h3:
      score: 1
      elementCount: 2
    ul:
      score: 1
      elementCount: 1
    li:
      score: 0.5
      elementCount: 3
  result: 4.5
regex:
  wordCount: 65
  wordValue: 0
  result: 0
0.90

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants