Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Delete tmp file and .bak file for android lint runs #980

Merged
merged 1 commit into from
Oct 13, 2023
Merged

Delete tmp file and .bak file for android lint runs #980

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion buildSrc/src/main/rocker/com/uber/okbuck/template/config/OkbuckTargets.rocker.raw
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -187,7 +187,9 @@ def okbuck_lint(
cmd += "--fullpath "

cmd += "{} `dirname {}` >$LOGFILE 2>/dev/null; ".format(" ".join(lint_options), toLocation(manifest))
cmd += "rm $CP_FILE; "

#Delete tmp file and tmp.bak file
cmd += "rm $CP_FILE*; "
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is needed because sed -i.bak is used above, and I left that alone for the sake of historical decisions on backing it up. I assume it was used to be preserved in the case of debugging failures.


native.genrule(
name = name,
Expand Down
Loading