Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable javac -parameters flag #1069

Merged
merged 1 commit into from
Nov 9, 2024
Merged

Conversation

msridhar
Copy link
Collaborator

@msridhar msridhar commented Nov 8, 2024

This enables Error Prone to discover more issues, e.g., we fix a couple of assertEquals argument ordering issues.

@msridhar msridhar enabled auto-merge (squash) November 8, 2024 16:55
Copy link

codecov bot commented Nov 8, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 87.86%. Comparing base (17fc1ba) to head (e3c55ec).
Report is 2 commits behind head on master.

Additional details and impacted files
@@             Coverage Diff              @@
##             master    #1069      +/-   ##
============================================
+ Coverage     87.66%   87.86%   +0.20%     
+ Complexity     2222     2211      -11     
============================================
  Files            86       85       -1     
  Lines          7271     7188      -83     
  Branches       1436     1425      -11     
============================================
- Hits           6374     6316      -58     
+ Misses          456      438      -18     
+ Partials        441      434       -7     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@yuxincs yuxincs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is awesome!

@msridhar msridhar merged commit 0a5fa0f into uber:master Nov 9, 2024
11 checks passed
@msridhar msridhar deleted the try-parameters-flag branch November 9, 2024 14:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants