Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Generated enum values are strings when numbers are needed #97

Open
NameFILIP opened this issue Oct 4, 2019 · 0 comments
Open

Generated enum values are strings when numbers are needed #97

NameFILIP opened this issue Oct 4, 2019 · 0 comments

Comments

@NameFILIP
Copy link
Contributor

NameFILIP commented Oct 4, 2019

Thrift enum:

enum SomeEnum {
    A = 1,
    B = 2,
    C = 3,
}

I need (as in response from Java code):

const SomeEnum = {
  A: 1,
  B: 2,
  C: 3,
}

but getting:

const SomeEnum = {
  A: 'A',
  B: 'B',
  C: 'C',
}

I think thriftrw uses strings as values (https://github.com/thriftrw/thriftrw-node#enums), but whatever is used on the Java server returns numbers, so I guess this should generate both variants.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant